Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug model edge language #1789

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Bug model edge language #1789

merged 4 commits into from
Jul 3, 2020

Conversation

vEpiphyte
Copy link
Contributor

  • Change model.edge.* language to use key value language instead of extended property language
  • Fix a printing issue for the storm Parser class help output

@vEpiphyte vEpiphyte added the bug label Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020 •
edited
Loading

Codecov Report

Merging #1789 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
- Coverage   96.16%   96.03%   -0.13%     
==========================================
  Files         139      139              
  Lines       26560    26561       +1     
==========================================
- Hits        25541    25509      -32     
- Misses       1019     1052      +33
Flag Coverage Δ
#linux 96.03% <100.00%> (-0.13%) ⬇️
#linux_replay 66.02% <100.00%> (-0.17%) ⬇️
Impacted Files Coverage Δ
synapse/lib/storm.py 97.99% <100.00%> (+<0.01%) ⬆️
synapse/lib/stormlib/model.py 100.00% <100.00%> (ø)
synapse/lib/spawn.py 89.03% <0.00%> (-8.39%) ⬇️
synapse/lib/lmdbslab.py 98.84% <0.00%> (-0.42%) ⬇️
synapse/common.py 96.41% <0.00%> (-0.33%) ⬇️
synapse/daemon.py 88.52% <0.00%> (-0.30%) ⬇️
synapse/tools/migrate_200.py 97.73% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a3bac...bc320b6. Read the comment docs.

@vEpiphyte vEpiphyte merged commit e0cc60e into master Jul 3, 2020
@vEpiphyte vEpiphyte deleted the bug_model_edge_language branch July 3, 2020 16:40
@vEpiphyte vEpiphyte added this to the v2.2.2 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemoritz mikemoritz mikemoritz approved these changes

@invisig0th invisig0th invisig0th approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vEpiphyte @invisig0th @mikemoritz